ruby-grape / grape / 33638599393

97%

master: 97%

Pull #2886

github

Compile the router's optimized map from the registered routes

`Router#compile!` built `@optimized_map` by walking
`Grape::HTTP_SUPPORTED_METHODS + ['*']`, but `#append` accepts a route for
any verb `route` was given. A route declared as, say, `route :query, '/search'`
was therefore kept in `@map` and left out of `@optimized_map` — the only map
`#match?` consults — so it could never be matched.

The route was not merely inert: `collect_route_config_per_pattern` builds the
resource's `Allow` header from the routes themselves, so the resource
advertised `Allow: OPTIONS, GET, QUERY, HEAD` and then answered every QUERY
request with 405, contradicting its own advertisement (RFC 9110 §10.2.1).

Compiling from `@map` instead makes the two agree, drops the now-redundant
`@map.key?` guard, and lets Grape serve methods it does not know about ahead
of time — RFC 10008's QUERY among them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1235 of 1330 branches covered (92.86%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

3921 of 3989 relevant lines covered (98.3%)

27377.18 hits per line