coreui / coreui-pro / 33624564328

93%

main: 94%

push

github

feat(ScrollSpy)!: activate sections on a configurable activation line and keep the last link highlighted in gaps (#1054)

* docs(scrollspy): describe the activation line, list topMargin and add the simple anchors example

The page now says how a section becomes active: the activation line set by
topMargin, the last link kept through gaps, the first link above the first
section and the last link at the bottom. The options table lists topMargin,
describes rootMargin as the raw observer override that wins when set and
shows threshold's new default. Examples move under one Examples heading in
the upstream order (navbar, nested nav, list group, simple anchors); the
navbar example drives a Menu instead of the deprecated Dropdown and the
simple anchors example, missing since the docs migration, is added. The
migration guide gets the user-visible changes of the new engine.

* feat(ScrollSpy)!: activate sections on a configurable activation line and keep the last link highlighted in gaps

The active link is now the lowest section whose top edge has crossed an
activation line drawn topMargin below the top of the scroll container
(12% by default, % or px). The result depends only on the scroll position:
the previous engine compared each section's offset with the last scroll
position and could highlight a different link for the same offset
depending on the scroll direction.

Two user-visible fixes follow. When a gap between sections crosses the
line, the last active link stays highlighted instead of the navigation
going blank. When the container is scrolled to the bottom, a sentinel
observer activates the last section even if it is too short for its top
to reach the line.

rootMargin defaults to null and is passed to the observer unchanged when
set, taking precedence over topMargin, so existing configurations keep
working. threshold defaults to [0]. A pixel topMargin rebuilds the
observer on resize (debounced). smoothScroll now settles the navigation:
once the sc... (continued)

4830 of 5430 branches covered (88.95%)

Branch coverage included in aggregate %.

179 of 186 new or added lines in 1 file covered. (96.24%)

9263 of 9687 relevant lines covered (95.62%)

399.54 hits per line