Mellanox / nic-configuration-operator / 33607049783
57%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 63
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 55.042% (-0.03%) from 55.071%
33607049783

push

github

web-flow 
docs: correct Spectrum-X profile reference and multiplane mode names (#471)

Four corrections to the Spectrum-X section, all internally inconsistent
with the rest of the same file.

Since 26.7.0 spectrumXOptimized.version names a Spectrum-X profile
ConfigMap rather than selecting a built-in Reference Architecture
version. The multiplane NicConfigurationTemplate example still passed
"RA2.1", which now resolves to a ConfigMap of that name. None exists,
and SpectrumXOptimizedSpec.Version is a free-form string with no enum
validation, so the template is accepted and Spectrum-X tuning is
silently never applied. Point it at example-spectrum-x-profile, the
ConfigMap this README defines and the standalone snippet already uses.

hwplb and swplb are expanded as "Packet Load Balancing". The mechanism
is the Plane Load Balancer: NVIDIA's Spectrum-X material describes the
PLB as a hardware engine in the SuperNIC that distributes packets
across network planes, and the Network Operator documentation and
Kubernetes Launch Kit both use "Plane Load Balancing" throughout.

The multiplane example also called hwplb ConnectX-8 only, contradicting
the mode table above it and the CRD's own validation message, which
reads "hwplb MultiplaneMode can only be enabled for ConnectX-8 (NicType
1023) or ConnectX-9 (NicType 1025)".

Signed-off-by: Alexander Petrovskiy <alexpe@nvidia.com>

5780 of 10501 relevant lines covered (55.04%)

0.64 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
81.12
 -1.02% internal/controller/nicfirmwaresource_controller.go
3
81.4
 -1.74% internal/controller/nicinterfacenametemplate_controller.go
Jobs
ID Job ID Ran Files Coverage
1 33607049783.1 63
55.04
 GitHub Action Run
Source Files on build 33607049783