33501449922
86%

Ran 01 Sep 2026 11:17AM UTC

Jobs 19

Files 514

Run time 2min

Badge

Embed ▾

Committed 01 Sep 2026 11:14AM UTC coverage: 83.586% (-0.006%) from 83.592%

Build # 33501449922

Build Type

push

github

Committed by

web-flow

Commit Message

test(nwo): wait for an FSC node to exit instead of sleeping (#1698)

* test(nwo): wait for an FSC node to exit instead of sleeping

StopFSCNode sent SIGTERM and returned, so a caller that restarted the node
raced the dying process for its ports and its vault. Callers papered over
this with time.Sleep(3s) on either side of the restart: one to hope the
node had gone, one to hope its replacement had come up. The second was
already redundant -- StartFSCNode waits for the node to log its start
check -- and the first was a guess.

Wait for the process to be gone, the way every other stop path in nwo
already does with StopEventuallyTimeout, and drop both sleeps from the
stoprestart suites.

Waiting means reading Runner.exitCode from the caller's goroutine while
the runner's monitor writes it, which the race detector flags, so make it
atomic. Two latent bugs fall out of pinning that value down: a cloned
Runner never initialised it, so a restarted node's runner reported a clean
exit before it had run, and a process whose OS exit status was -1 stored
that as its exit code -- indistinguishable from "still running", which
would have hung the new wait until it timed out.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

30886 of 36951 relevant lines covered (83.59%)

2815.94 hits per line

Coverage Regressions

Lines	Coverage	∆	File
3	91.37	0.0%	platform/view/services/comm/p2p.go
2	97.22	-2.78%	platform/common/utils/lazy/provider.go
2	90.72	-2.06%	platform/view/services/comm/service.go
2	54.96	-1.53%	platform/fabricx/core/channel/wrappers.go
2	92.71	-1.04%	platform/fabric/core/generic/ordering/bft.go
1	97.83	-0.31%	platform/fabricx/core/finality/nlm.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	itest-fsc-pingpong - 33501449922.1	01 Sep 2026 11:22AM UTC	262	33.52	GitHub Action Run
2	itest-fabric-stoprestart - 33501449922.2	01 Sep 2026 11:21AM UTC	458	32.23	GitHub Action Run
3	itest-fabric-iou - 33501449922.3	01 Sep 2026 11:24AM UTC	468	41.61	GitHub Action Run
4	itest-fabric-atsa - 33501449922.4	01 Sep 2026 11:23AM UTC	458	44.82	GitHub Action Run
5	utest-postgres - 33501449922.5	01 Sep 2026 11:18AM UTC	505	10.3	GitHub Action Run
6	itest-fabricx-atsa - 33501449922.6	01 Sep 2026 11:17AM UTC	487	31.0	GitHub Action Run
7	itest-fsc-signedpingpong - 33501449922.7	01 Sep 2026 11:17AM UTC	256	30.6	GitHub Action Run
8	itest-fabricx-simple - 33501449922.8	01 Sep 2026 11:17AM UTC	485	28.21	GitHub Action Run
9	itest-fabric-iouhsm - 33501449922.9	01 Sep 2026 11:23AM UTC	468	40.78	GitHub Action Run
10	itest-fabric-events - 33501449922.10	01 Sep 2026 11:19AM UTC	463	28.57	GitHub Action Run
11	itest-fsc-stoprestart - 33501449922.11	01 Sep 2026 11:19AM UTC	258	32.52	GitHub Action Run
12	itest-fabricx-multiendorsement - 33501449922.12	01 Sep 2026 11:17AM UTC	485	28.95	GitHub Action Run
13	utest - 33501449922.13	01 Sep 2026 11:21AM UTC	505	76.04	GitHub Action Run
14	itest-fabric-configupdate - 33501449922.14	01 Sep 2026 11:19AM UTC	468	39.06	GitHub Action Run
15	itest-fabric-runtimeconfig - 33501449922.15	01 Sep 2026 11:19AM UTC	468	39.25	GitHub Action Run
16	itest-fabricx-deployment - 33501449922.16	01 Sep 2026 11:17AM UTC	485	28.93	GitHub Action Run
17	itest-fabricx-iou - 33501449922.17	01 Sep 2026 11:17AM UTC	487	29.38	GitHub Action Run
18	itest-fabric-atsachaincode - 33501449922.18	01 Sep 2026 11:19AM UTC	463	31.37	GitHub Action Run
19	itest-fabric-twonets - 33501449922.19	01 Sep 2026 11:19AM UTC	458	30.22	GitHub Action Run

hyperledger-labs / fabric-smart-client / 33501449922
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 33501449922

hyperledger-labs / fabric-smart-client / 33501449922 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 33501449922

hyperledger-labs / fabric-smart-client / 33501449922
86%

README BADGES
x