enbility / ship-go / 33493256316
93%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 46
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.092% (+0.03%) from 93.061%
33493256316

push

github

web-flow 
ci: give the race detection job a workable timeout (#111)

`go test -race -timeout=90s -count=3 ./ship ./hub` gives **each test
binary** a 90s budget. `./hub` needs ~30s per `-race` run, so `-count=3`
lands at ~88s locally — inside the budget, with no headroom at all:

```
ok  github.com/enbility/ship-go/ship  29.031s
ok  github.com/enbility/ship-go/hub   88.360s
```

On a GitHub runner it tips over and the job fails with `panic: test
timed out after 1m30s`. The dump reads like a deadlock, but the
goroutines it names are ordinary: the `running tests:` header shows only
`TestHubConnectionsServerSuite` (2s in), and the two live goroutines are
a `time.Sleep` inside the test and the 500ms delayed-callback goroutine
from `HandleShipHandshakeStateUpdate`. Nothing is stuck — the clock ran
out mid-suite.

This is not tied to any one branch. The same job has been flapping on
`dev` for weeks; run 33413520498 (PR #109, an mdns-only change) is just
the latest to hit it.

### Change

Raise the timeout on that one step to 300s. Still well inside the job's
`timeout-minutes: 15`. The other `-timeout=90s` steps in the file are
`-count=1` or `-run`-filtered subsets and have plenty of margin.

Not addressed here: `./hub` spending ~13s of its 30s in
`TestHandleShipHandshakeStateUpdateTestSuite`, where ~25 tests each wait
out the hardcoded 500ms delay in `hub_shipconnection.go`. Making that
delay injectable would cut the runtime by a third — worth its own PR.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

6024 of 6471 relevant lines covered (93.09%)

14951.68 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
81.11
 0.0% cert/cert.go
2
96.17
 0.0% mdns/avahi.go
Jobs
ID Job ID Ran Files Coverage
1 33493256316.1 46
93.09
 GitHub Action Run
Source Files on build 33493256316