php-bug-catcher / reporter-bundle / 33484679483

77%

Build Type

push

github

Committed by tito10047

Commit Message

fix: include the throw site as the first stack trace frame

BugCatcher::logException() fed the raw getTraceAsString() into the frame
parser. That string never contains the throw site -- its #0 is already the
caller of the frame that threw -- so the frame where the exception actually
originated was missing and every frame appeared shifted by one.

The Monolog path worked around this by prepending a synthetic
"#0 file(line): message" text line in ErrorFormater and parsing it back, but
the vendor regex '/#\d+ (.*)\((\d+)\): (.*)/' is greedy: a message containing
"(1064): " swallowed the real file and line.

Build the first Codeframe straight from the Throwable instead. The new
ThrowSiteStacktrace extends the vendor parser to reuse its protected
isValidFile()/getTheCodeFromTheFile(), so the synthetic frame carries the same
code window as the parsed ones, and it also walks the getPrevious() chain,
which ErrorFormater used to drop entirely.

Both send paths now go through it: WriteStackTraceListener always, and
BugCatcherMonologHandler whenever context['exception'] holds a Throwable,
falling back to the formatted string otherwise. The payload format is
unchanged, so no server or config changes are needed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

23 of 26 new or added lines in 4 files covered. (88.46%)

3 existing lines in 1 file now uncovered.

123 of 160 relevant lines covered (76.88%)

17.33 hits per line