moonbitlang / core / 6467

89%

push

github

refactor(builtin): add Array::Array constructor, deprecate Array::new

Array::new was one of the last holdouts of the `T::T` constructor
convention already adopted by Map, HashMap, Set, Deque, Queue, SortedMap,
HashSet, PriorityQueue and SortedSet, whose `::new` forms now live in
deprecated.mbt.

Renames `Array::new(capacity?)` to `Array::Array(capacity?)` on both the
js and non-js backends, enabling the bare `Array(capacity=...)` sugar,
and keeps `Array::new` as a deprecated shim.

Unlike the container types, the positional ArrayView slot of the
`T::T(ArrayView, capacity?)` shape is omitted: for Array it degenerates
into a copy constructor, and a direct rename keeps downstream migration a
plain textual substitution of `Array::new(` to `Array(`.

Json also declares an `Array` constructor, so within the builtin package
the bare form is ambiguous and three call sites spell it `Array::Array`.
Outside builtin both the annotated and inferred forms resolve cleanly.

24 of 24 new or added lines in 16 files covered. (100.0%)

16880 of 18548 relevant lines covered (91.01%)

283166.18 hits per line