umputun / ralphex / 33433152882

86%

push

github

fix: archive the completed plan on the feature branch (#451)

* fix: archive the completed plan on the feature branch (#450)

Under --worktree the archive ran against the user's main checkout, so the
"move completed plan" commit landed on whatever branch that checkout sat on.
Unpushable under branch protection, absent from the feature PR, and for a
plan that was untracked on master it *added* an unticked completed/ copy
there that merged cleanly alongside the branch's ticked original - leaving
two plans and no real archive.

archivePlan now always uses req.GitSvc/req.PlanFile, which in worktree mode
are the worktree's service and the ticked copy. MainGitSvc and MainPlanFile
are removed rather than bypassed. The archive runs before DiffStats and the
completion notification so the plan rename is part of the branch they
describe - this affects normal mode too, where the archive already landed on
the feature branch.

A rejected archive commit now retains the worktree instead of letting
"worktree remove --force" discard the staged rename (#439). The run still
exits green; the summary names the retained worktree and says
"git -C <root> status", since a bare git status after the chdir back
inspects the main checkout.

The main checkout's plan copy is deliberately left in place - it is the
user's file and often untracked. The dashboard consequence stays in
docs/backlog/worktree-archives-unticked-plan.md, with its causality
corrected.

core.hooksPath is pinned in setupTestRepo so a global hooks path cannot
decide which hooks these tests' commits run.

* fix: name the branch a worktree archive landed on, and correct its recovery guidance

Follow-up to 1de13143, from a multi-agent review of that commit.

The completion summary was worse after the archive moved onto the feature
branch, not better. It derives the path from the worktree copy and renders
it relative to a CWD that is still the worktree, so a successful run printed
"plan: docs/plans/completed/feature.... (continued)

55 of 59 new or added lines in 2 files covered. (93.22%)

8184 of 9519 relevant lines covered (85.98%)

223.81 hits per line