kcl-lang / kcl-go / 33409544911

29%

main: 29%

Build Type

Pull #589

github

Committed by Peefy

Commit Message

feat(gen): support type-only if conditions in JSON Schema import (fixes kcl-lang/kcl#1876)

A JSON Schema `if` subschema that consists only of a `type` keyword —
the common `if: {type: "string"}` guard on properties declared as
`type: ["string", "null"]` — produced no KCL expression, so the whole
if/then/else triple was dropped with a
"[WARN] unsupported if condition" and the `then` constraints (e.g.
`maxLength: 255`) were silently lost.

Emit the guard as `typeof(field) == "<type>"`, but only when the
enclosing schema itself declares a union type: for a single-typed
field the property declaration already enforces the type and a typeof
check would spuriously fail for int literals assigned to float fields.

Related fixes in the same area:

- validator.gotmpl: `{{if $then}}`/`{{if $else}}` test the condResult
  struct, which is always truthy, so a triple with a usable `then` and
  no `else` rendered a dangling ` if not (...)` check with an empty
  left-hand side. Test `.Expr` instead.
- condExpr: skip the redundant truthiness guard when the condition is
  a typeof check, which is already False for None, avoiding
  `... if typeof(f) == "str" and f`.
- document why `null` stays out of type unions: KCL has no `None` type
  annotation; nullability is expressed with the `?` modifier.

Also add a cgo-gated test that executes the generated schema and
asserts the semantics: None stays valid, an over-long string is
rejected, and the $ref'd default applies.

Signed-off-by: Peefy <peefy@qq.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Pull Request Pull Request #589: feat(gen): support type-only if conditions in JSON Schema import

Coverage Stats

39 of 50 new or added lines in 2 files covered. (78.0%)

7 existing lines in 2 files now uncovered.

4867 of 16567 relevant lines covered (29.38%)

2.02 hits per line