aas-core-works / aas-core-codegen / 33398911336

85%

push

github

Avoid naming conflicts in Java (#662)

We adapted the live test for enumerations to Java. Its meta-model
defines an enumeration literally named Result, and running the live
test revealed that this collided with the internal ``Result<T>`` helper
class used by the Jsonization and Xmlization generators for the
try-parse pattern, producing ill-typed code such as ``Result<Result>``
that failed to compile.

We analyzed the Java generators for every other internal class prone
to the same kind of collision, *i.e.* classes not part of the public
SDK surface, yet visible in files that wildcard-import the
meta-model types. We renamed each of them with a leading underscore:
``Result``, ``Transformer`` and ``DeserializeImplementation`` in Jsonization and
Xmlization; ``VisitorWithWriter`` in Xmlization; ``ShallowCopier`` and
``DeepCopier`` in Copying; ``Transformer``, ``ValidationErrorIterable``, ``Pair``
and ``EnumValueSet`` in Verification; ``Wrapper`` in Enhancing (including its
file name); ``ImmutableCollector`` in Constants; the per-class descend
iterators in the generated classes; and, in the generated test code,
``DeepEqualiser`` and ``Pair`` in TestCopying, ``Enhancement`` in TestEnhancing,
and ``TracingVisitorThrough`` in TestDescendAndVisitorThrough.

The live tests for ``enum``, ``primitive_types``, ``problematic_keywords`` and
``aas_core_meta.v3`` now pass, and so do the unit tests.

9 of 10 new or added lines in 5 files covered. (90.0%)

30642 of 36283 relevant lines covered (84.45%)

2.53 hits per line