ruby-grape / grape / 33382111996

97%

master: 97%

Pull #2877

github

Write route_info into the path captures instead of merging two hashes

`Router#process_route` built the routing args from two hashes on every matched
request — one holding `route_info`, one holding the path captures — and merged
the second into the first:

    route_params = route.params_for(input)
    routing_args = { route_info: route }
    routing_args.merge!(route_params) if route_params.present?

`params_for` already returns a fresh Hash that nothing else holds, so the second
one is redundant: `route_info` can be written straight into it. Measured in one
process, on a route with one capture:

    two hashes + merge   322 ns   ->   one hash + []=   218 ns   1.48x

and one fewer object per request end to end.

The rebuild-per-attempt behaviour that #2824 depends on is unchanged — a
cascading route still cannot leak its `route_info` or captures into the next
candidate, because a fresh Hash is still built for each attempt.

One ordering consequence. A path param literally named `route_info` used to
overwrite the route object during the merge, leaving `DSL::InsideRoute#route`
answering a String; it is now shadowed by the route object instead. Neither
spelling was usable — `Request#routing_args_as_params` excludes `:route_info`
from params either way — but the internal key winning is the safer of the two.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1236 of 1328 branches covered (93.07%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

3896 of 3964 relevant lines covered (98.28%)

27153.98 hits per line