supabase / edge-runtime / 33377412025

53%

Build Type

push

github

Committed by web-flow

Commit Message

fix(deno_crypto): return errors instead of aborting on malformed WebCrypto keys (#727)

Two `crypto.subtle` paths in deno_crypto 0.196.0 panic on user-supplied key
material. Because the panics happen inside op functions that cannot unwind,
they abort the whole process rather than surfacing a JS exception, so a single
edge function can take the runtime down.

1. `importKey("pkcs8", ...)` for EC keys unwraps the conversion of the PKCS#8
   AlgorithmIdentifier parameters into a named-curve OID. A key that encodes
   explicit EC parameters (a SEQUENCE) instead of a curve OID aborts with:

     called `Result::unwrap()` on an `Err` value: Error { kind: TagUnexpected {
       expected: Some(Tag(0x06: OBJECT IDENTIFIER)), actual: Tag(0x30: SEQUENCE) } }

2. `importKey("raw", ...)` for X25519/X448/Ed25519 never validates the key
   length, so a shorter key (e.g. an empty Uint8Array) is stored as-is and the
   subsequent `deriveBits` aborts in `op_crypto_derive_bits_{x25519,x448}` when
   converting the slice to a fixed-size array.

Both are fixed upstream (denoland/deno#32410 and denoland/deno#33944), but the
releases carrying them require a deno_core bump we cannot take here, so vendor
deno_crypto 0.196.0 and cherry-pick the two fixes. The vendored tree is
otherwise byte-identical to the published crate.

Malformed input now raises a DataError DOMException and the worker survives.
Valid keys are unaffected.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

0 of 2 new or added lines in 1 file covered. (0.0%)

14 existing lines in 5 files now uncovered.

19587 of 36682 relevant lines covered (53.4%)

8325.77 hits per line