bleedingdeacons / monitor / 33369901949
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 16
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.324%. Remained the same
33369901949

push

github

web-flow 
fix(compose): make the compose screen reachable, and stop it crashing (#37)

Two defects, both invisible to the build and both found the moment the
feature was opened on a handset.

The screen could not be reached. Its entry point was a ToolbarItem, but
AppShell sets Shell.NavBarIsVisible="False" on the alerts page, so there
is no bar for one to appear in - it rendered nowhere at all. The XAML
looked right and the button simply did not exist on the phone. It is now
a button at the base of the duty screen, beside Hide, where the other
two non-alert actions already live.

And opening it crashed the app. ComposePage bound a committee's indent
through toolkit:DoubleToThicknessConverter, which the Community Toolkit
does not ship. A converter that does not exist compiles perfectly and
then throws XamlParseException - "MarkupExtension not found" - as the
page loads, taking the process down. The indent is now a transparent
BoxView spacer, which needs nothing that has to exist.

The level radios had the same shape of problem in waiting: they bound
IsChecked through toolkit:IsEqualConverter. Replaced with three plain
booleans on the view-model. The only converters left in this app's XAML
are the two that were already proven in it.

Verified on a Pixel 6a against the deployed test bed: the button appears
(bound to CanSend, so the server's can_send round-tripped), the compose
screen renders, the member list shows anonymous name with home group and
labels the unreachable, the committee tree loads with its handset counts,
and a send to a committee whose only handsets are the sender's own is
refused with "Nobody on that committee has a handset enrolled" rather
than silently reporting success.

1287 of 1394 relevant lines covered (92.32%)

1260.61 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33369901949.1 16
92.32
GitHub Action Run
Source Files on build 33369901949