Kikobeats / cacheable-response / 33366659063

99%

push

github

fix: detect force bypass when req.query is a raw query string (#146)

* fix: detect force bypass when req.query is a raw string

router-http stores the raw query string on req.query. hasQueryParameter
treated any truthy value as a parsed object, so req.query['force'] was
undefined and ?force=true served a HIT instead of BYPASS.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* test: assert HIT after raw-query bypass

Prove the regenerated copy is stored, not only served. Shorten the
type-guard comment to one line.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>

66 of 70 branches covered (94.29%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

224 of 224 relevant lines covered (100.0%)

43.13 hits per line