Kikobeats / cacheable-response
99%

DEFAULT BRANCH: master
Repo Added
Files 2
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x

coverage: 98.855% (+0.004%) from 98.851%
28431450579

push

github

web-flow 
fix: skip 304 short-circuit when get bypasses cache (#140)

* fix: skip 304 short-circuit when get bypasses cache

Returning null/undefined from .get() is a documented cache bypass. After
#138 stopped the null crash, matching If-None-Match still triggered a 304
with an empty body because the etag was derived from the {} fallback while
send() was never called.

Only return 304 when memoize produced a stored value (raw is truthy).

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* refactor: gate 304 short-circuit on hasValue instead of raw

The 304 revalidation should fire only when memoize actually had a stored
value. `hasValue` is the semantic flag from @keyvhq/memoize for exactly
that, already destructured at the call site. Gating on `raw` truthiness
worked for the documented bypass case only because compress(undefined)
returns undefined, an implicit coupling; hasValue also stays correct when
.get() returns a falsy primitive.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

57 of 60 branches covered (95.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

202 of 202 relevant lines covered (100.0%)

30.97 hits per line

Relevant lines Covered
202 RELEVANT LINES 202 COVERED LINES
30.97 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28431450579 master fix: skip 304 short-circuit when get bypasses cache (#140) * fix: skip 304 short-circuit when get bypasses cache Returning null/undefined from .get() is a documented cache bypass. After #138 stopped the null crash, matching If-None-Match still t... push web-flow github
98.85
28431142346 cursor/critical-bug-investigation-87a9 Merge fa54f4a81 into 35727b198 Pull #140 web-flow github
98.85
28419665986 cursor/critical-bug-investigation-87a9 Merge b80d5bde6 into 35727b198 Pull #140 web-flow github
98.85
27829390638 master build(deps): bump actions/checkout from 6 to 7 (#139) Bumps [actions/checkout](https://github.com/actions/checkout) from 6 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blo... push web-flow github
98.85
27819567189 dependabot/github_actions/actions/checkout-7 Merge 7d8fb9098 into 17da0d73e Pull #139 web-flow github
98.85
27602732204 master fix: handle null return from get without crashing (#138) Returning null from .get() is documented as a cache bypass alongside undefined, but typeof null === 'object' caused an uncaught TypeError when assigning etag. Normalize null to undefined so... push web-flow github
98.85
27593674754 cursor/critical-bug-investigation-a0e5 Merge 6cfe9597a into 19428cb92 Pull #138 web-flow github
98.85
27492456160 master chore: update dependencies (#137) push web-flow github
99.22
27492431974 next Merge caec31d74 into caf7bad3f Pull #137 web-flow github
99.22
27487911485 cursor/critical-bug-investigation-fbca Merge ae6d46ba2 into caf7bad3f Pull #136 web-flow github
97.54
See All Builds (391)