dennisdoomen / packageguard / 33360051396

81%

main: 81%

push

github

Resolve the nuspec repository URL before falling back to GitHub for a license (#248)

The GitHub license fallback reads a package's repository URL to look up
its license via GitHub's API. That URL was being set from the NuGet
catalog's projectUrl first, and only overwritten with the more accurate
repository URL from the package's nuspec afterwards - after the GitHub
fallback had already run and failed.

For packages whose projectUrl points somewhere other than their source
repository (e.g. a blog post) while their nuspec correctly declares a
GitHub repository, this meant the license could never be resolved, even
though the information needed to resolve it was available. NetArchTest.Rules
1.3.2 is a concrete example: it declares no license or license URL, its
projectUrl points to a blog post, and its nuspec repository element points
at its MIT-licensed GitHub repository.

Applying the nuspec repository URL before attempting the license fallback
lets the GitHub lookup use the real repository instead.

The regression test restores an actual project referencing NetArchTest.Rules
rather than relying on the package already sitting in the local NuGet cache,
since the fix depends on the nuspec that only a real restore provides.

1945 of 2686 branches covered (72.41%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

6208 of 7410 relevant lines covered (83.78%)

1712.48 hits per line