dennisdoomen / packageguard / 33245800566

81%

push

github

Model --report-risk's optional path as a real Spectre.Console.Cli option (#247)

* Model --report-risk's optional path as a real Spectre.Console.Cli option

AnalyzeCommandSettings.ReportRisk used to be a plain bool, with the
optional path value bound entirely outside Spectre: Program.cs
pre-scanned raw argv via ReportRiskArgumentNormalizer.Normalize(args)
before Spectre parsed anything, stashing the result in the
PACKAGEGUARD_REPORT_RISK_PATH_OVERRIDE environment variable for
GetReportRiskPath() to read back. That made the path invisible to
--help and to anything introspecting AnalyzeCommandSettings.

Spectre.Console.Cli has first-class support for this shape via
FlagValue<T> plus an optional value token ([PATH]) in the option
template. ReportRiskOption is now a FlagValue<string>, bound directly
by Spectre; ReportRisk and GetReportRiskPath() are thin wrappers over
IsSet/Value. This removes the argv pre-scan, the env var, and
ReportRiskArgumentNormalizer entirely, and makes --report-risk [PATH]
show up correctly in --help.

Fixes https://github.com/dennisdoomen/packageguard/issues/245

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Address github-advanced-security InspectCode findings on PR #247

- Capture CapturingCommand.LastSettings into a local before asserting
  and dereferencing it, so the possible-null-reference warning on a
  repeated static-property read is resolved.
- Mark CapturingCommand [UsedImplicitly] since it's only referenced as
  a generic type argument (CommandApp<CapturingCommand>) and
  instantiated by Spectre.Console.Cli via reflection, which InspectCode
  can't see.
- Drop the redundant nullable annotation on the local in
  GetReportRiskPath(); ReportRiskOption.Value is not nullable here.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

1944 of 2686 branches covered (72.38%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 2 files covered. (75.0%)

6208 of 7410 relevant lines covered (83.78%)

1710.35 hits per line