ruby-grape / grape / 33320359178

97%

master: 100%

Pull #2871

github

Keep `refresh_already_mounted` out of `mount`'s public signature

`mount` accepted an undocumented `refresh_already_mounted` option that
replaced any endpoint already mounted for the same base API instead of
adding a second one. The behaviour is essential — `Grape::API.refresh_mount_step`
replays every earlier mount when a class-level method runs after one, and
replaying without it duplicates the endpoint (a single `format :json` after
a mount turns 1 endpoint into 3) — but the decision belongs to the replay,
not to the call.

Its only legitimate caller, the private `refresh_mounted_api`, always passed
true, so the option existed solely to carry a constant from a private method
through a public one. Move the replacement into `refresh_mounted_api`, which
is possible because a mounted API's throwaway instance and the class that was
written share a base, the same signal `same_mounted_app?` already keys on.
Passing the option to `mount` warns and still works.

Two things fall out of no longer threading an internal flag through the
signature:

`mounts.respond_to?(:each_pair)` becomes `mounts.is_a?(Hash)`. A Struct and
an OpenStruct answer `each_pair` without being able to express an app => path
mapping, so a Rack app that happened to be one was read as a mapping and
mounted its own field value as a path. The normalisation is shared with the
endpoint replacement rather than written twice.

`*opts` becomes `opts = {}`. The splat could only ever hold one element, so
every read spelled `opts.any? ? opts.first[:key] : default`. It stays
positional: `mount` must declare no keywords, or Ruby routes the brace-less
Hash of `mount App => '/path'` to them and the mount itself goes missing.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1230 of 1322 branches covered (93.04%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

3889 of 3957 relevant lines covered (98.28%)

27175.63 hits per line