ruby-grape / grape / 33320069736

97%

master: 100%

Pull #2867

github

Name the group-merged options instead of rebinding `opts`

`opts = @group.deep_merge(opts) if @group` never modified what the caller
passed — `deep_merge` returns a new Hash, and the assignment only rebinds a
local — but it left one name meaning two things: the options as declared
before the line, and the options resolved against the enclosing `with`
after it. Every read below the line has to know which side it is on, and
that ambiguity is what put the group type and the presence message on the
wrong side of the merge in the first place.

Give the resolved value its own name, the way `with` already does two
methods up:

    new_group_attrs = @group&.deep_merge(opts) || opts

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1232 of 1324 branches covered (93.05%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 2 files covered. (100.0%)

3888 of 3956 relevant lines covered (98.28%)

27109.17 hits per line