ruby-grape / grape / 33320065748

97%

master: 97%

Pull #2870

github

Take `declared_params_scope` as a keyword instead of stamping it into opts

`push_declared_params` wrote the scope into the options Hash and guarded
the write so a later call could not overwrite it:

    opts[:declared_params_scope] = self unless opts.key?(:declared_params_scope)
    return @parent.push_declared_params(attrs, **opts) if lateral?

That pair is doing something the code never says. A lateral scope — the one
a `given` block opens — does not store its own declared params; it hands
them to its parent. The stamp is how the attribute stays attributed to the
scope that declared it rather than the one that stores it, which is what
`declared(evaluate_given: true)` later reads through
`attr_meets_dependency?`. Reconstructing that means noticing the guard three
lines below the write.

A default keyword argument states it outright: the receiver when nobody
supplied one, forwarded unchanged when a lateral scope did. Ruby evaluates
the default in the receiver's context, so the semantics are identical.

`as` becomes explicit at the same time, leaving no `**opts` to inspect: both
options a caller may pass are now in the signature.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1239 of 1330 branches covered (93.16%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

3889 of 3957 relevant lines covered (98.28%)

27011.37 hits per line