Tatsh / dade / 33297324321

100%

push

github

sopranos: read a texture bank that reserves an empty slot

A bank reserves a slot for every image the code reading it may ask for by
number, and a slot the build had nothing to put in holds a zero offset
rather than an address. Treating that as damage threw away whole banks
over one hole: p_creggiesapt2.TEX2 lost all fifteen of its images to a
single empty slot, and the poker HUD lost its one image to fourteen.

The file that settles it is the slots HUD bank, which is exactly a header
and five empty slots, thirty-two bytes with no image data at all. A bank
holding nothing is well formed, so an empty slot is skipped and only a
non-zero offset past the end is still an error. The retail disc now
converts without --ignore-failures.

Also correct archive_directory: the _P in DATA_P.FS is not a region code,
since the NTSC-U disc SLUS-21388 carries it too.

4710 of 4710 branches covered (100.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

18271 of 18271 relevant lines covered (100.0%)

5.0 hits per line