libevent / libevent / 33260573040

81%

Build Type

push

github

Committed by azat

Commit Message

ws: free the connection on BEV_EVENT_ERROR, not only BEV_EVENT_EOF

ws_evhttp_error_cb() only freed the evws_connection on BEV_EVENT_EOF, so an
abrupt peer reset or a failed write (BEV_EVENT_ERROR, e.g. ECONNRESET/EPIPE)
never reached evws_connection_free(). As a result the user close callback
registered via evws_connection_set_closecb() was never invoked, and the
connection and its bufferevent leaked.

This shows up with a client that resets right after the upgrade, before
sending a WebSocket close frame -- a browser tab closed without a clean
close, a flaky-network RST, or `curl ... | head -1` getting SIGPIPE'd on the
first server write. A fraction of such connections were left un-freed.

Handle BEV_EVENT_ERROR by freeing the session immediately, mirroring
close_event_cb(). The BEV_EVENT_EOF path is unchanged, so pending output is
still flushed on a graceful close.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

0 of 2 new or added lines in 1 file covered. (0.0%)

4 existing lines in 3 files now uncovered.

13023 of 16039 relevant lines covered (81.2%)

809290.18 hits per line