stacklok / toolhive / 33208280784

70%

Build Type

push

github

Committed by web-flow

Commit Message

Degrade transient optional list failures in Modern enumeration (#6348)

* Degrade optional lists on transient Modern errors

A rate-limited Modern backend that answers an optional capability
enumeration (resources/list, resources/templates/list or prompts/list)
with a transient HTTP 429 was misclassified as ErrBackendUnavailable,
flipping a reachable backend to unhealthy/degraded and aggregate
Ready=false even though initialize and tools/list succeeded.

Degrade a transient failure on an optional list to an empty result
instead of failing the whole enumeration. tools/list stays fatal; the
-32601 not-implemented degradation is unchanged.

Fixes #6347

Signed-off-by: lorenzozanee <wyz0707@proton.me>

* refactor: deduplicate optional list degradation into modernListOptional

Extract the three nearly-identical optional-list degradation switches in
modernEnumerate into a single modernListOptional helper, dropping the
function's cyclomatic complexity back under the gocyclo threshold (15).
Behavior is unchanged: a transient list failure degrades with a WARN, a
-32601 degrades only for resources/templates/list (mirroring the Legacy
path), and tools/list stays fatal.

---------

Signed-off-by: lorenzozanee <wyz0707@proton.me>
Co-authored-by: reyortiz3 <reynier@stacklok.com>

Coverage Stats

16 of 18 new or added lines in 1 file covered. (88.89%)

7 existing lines in 3 files now uncovered.

76357 of 109546 relevant lines covered (69.7%)

91.83 hits per line