solidjs / solid / 33200206109

72%

main: 89%

push

github

feat(compiler): register call-shaped component bindings in refresh (#3090)

A factory-created component export (styled(), an HOC call, a tagged
template) was never registered by the refresh pass, and once any
registered sibling made the module self-accept, hot.accept() disabled
the module-invalidation fallback its staleness relied on — the export
went permanently stale, silently. Two compile-time admission gates fix
this: a call-shaped top-level binding rendered as a JSX tag in its own
module is proven a component and registers automatically (scope-aware —
shadowing locals don't count), and the per-binding @refresh component
pragma asserts it for export-only shapes with no in-module usage.
Registered call bindings get location, granular signature (the
signature printer already covers calls and tagged templates), and
dependencies, with same-module registered components excluded from the
dependency set — their proxy identity changes every re-execution while
edits propagate through the proxy chain, so counting them would remount
the consumer on every edit of the module. Deliberate native-first
divergence from the frozen Babel reference, like the merged-function
handling; the runtime needs nothing new (devComponent brands through
the proxy's set trap before the swap branch checks it).

Co-authored-by: Cursor <cursoragent@cursor.com>

517 of 789 branches covered (65.53%)

Branch coverage included in aggregate %.

767 of 1003 relevant lines covered (76.47%)

14.52 hits per line