archetech / archon / 33188705508

94%

main: 95%

push

github

ci: One publish workflow, publishing what it builds (#956)

* ci: One publish workflow, publishing what it builds

There were two, and they had drifted. release-publish.yml ran on v* tags
and shipped 6 images; docker-publish.yml ran on the pre-release branch
and shipped 15. So a release published a quarter of the twenty-six
services, and nine images had a `latest` that only ever came from the
pre-release branch -- a tag implying a currency it did not have.

They also disagreed on a name. The same docker/Dockerfile.satoshi went
out as `sat-mediator` from a release and `satoshi-mediator` from
pre-release: two packages for one service, and an operator looking for
the name every other mediator uses found the one fed by pre-release.

Now one workflow, with the channel deciding the tags rather than the
workflow deciding the images:

  v* tag           -> <version> + latest
  pre-release push -> <calver>  + pre-release

The matrix is the build matrix, all twenty-seven images.
`satoshi-mediator` is canonical, matching the Dockerfile and every other
entry, and `sat-mediator` is published alongside it from the same build
so pulls from before the rename keep working. It can go once nothing
uses it.

Nothing structural stops the matrices drifting again -- Actions cannot
share a matrix between workflows -- so tests/ci/image-matrix.test.ts
asserts it: every tracked Dockerfile is built, publish matches build
exactly, image names are unique, no name carries a network, and the one
alias is the one we meant. Removing an image, renaming zcash-mediator to
zcash-mainnet-mediator, adding a second alias, or dropping a Dockerfile
from the build matrix each fail their own test.

The network point is worth stating: compose selects eth-sepolia,
sol-devnet or zcash-mainnet, and one image serves all of them. Naming an
image for a deployment would make it unusable on the others while
reading as though it were pinned.

Closes #954

* fix(test): Declare the types for js-yaml

The ne... (continued)

3881 of 4464 branches covered (86.94%)

Branch coverage included in aggregate %.

8527 of 8952 relevant lines covered (95.25%)

717.63 hits per line