bleedingdeacons / monitor / 33085466356
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 13
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.221% (+0.05%) from 96.173%
33085466356

push

github

web-flow 
feat: clear an answered message, and keep the card you answered

Two halves of the same change, and they pull in opposite directions on
purpose.

On every other handset the message is now **removed** rather than marked
answered. An answered message is over: the responder who took it has the
job, and leaving thirty other people a card to dismiss one by one is
work invented for no reason. Matched on the message uuid rather than the
alert id, because the id a notice could quote belongs to whichever copy
the other responder happened to answer. If it was the last outstanding
alert the alarm stops with it — a handset left ringing about a job
somebody else has taken is the thing this feature exists to remove.

On the handset that answered, the card now **stays**. Acknowledging used
to remove it, which took the reference and the Show contact button away
at exactly the moment they started to matter: the responder has just
accepted a call and now has to make it. So Acknowledge silences the
alarm, drops the tray notification and tells Reach, and the card remains
saying "Acknowledged by you" with Close in place of Acknowledge. The
second press closes it, locally — Reach was told the first time.

Acknowledge all is the other thing and still clears the screen. Nobody
takes on five jobs by pressing one button.

Two consequences worth naming. The alarm now counts what is outstanding
rather than what is listed, because a settled card stays on screen and
must not keep it ringing. And it is asked to stop only when it is
actually sounding: clearing the last card in two steps — settle, then
close — stopped it twice, which is harmless on the current alarm and
exactly the sort of thing that stops being harmless later.

Needs the matching Reach change to be complete: local removal alone
would be undone by the next poll.

993 of 1032 relevant lines covered (96.22%)

18.73 hits per line

Coverage Regressions

Lines Coverage ∆ File
20
94.31
0.39% Services/AlertService.cs
Jobs
ID Job ID Ran Files Coverage
1 33085466356.1 13
96.22
GitHub Action Run
Source Files on build 33085466356