bleedingdeacons / monitor / 33080820098
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 13
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.173%. Remained the same
33080820098

push

github

web-flow 
fix: make the notification service extension compile

* fix: give the notification service extension the constructor iOS needs

The class declared no constructor at all, so the compiler synthesised a
parameterless one whose implicit base() call had nothing to bind to —
UNNotificationServiceExtension, like every NSObject the Objective-C
runtime instantiates, exposes only handle-taking constructors. CS1729,
on the class declaration.

Not a Windows artefact: it would have failed on a Mac too. It went
unnoticed because nothing compiles this project — CI builds the Android
head alone, and ci.yml already records that the extension is unbuilt
source until somebody opens it on a Mac. That is exactly the kind of
thing an unbuilt project accumulates.

iOS instantiates the extension from the class name in Info.plist's
NSExtensionPrincipalClass, so what arrives is a handle to an object that
already exists and the constructor's job is to adopt it. public rather
than the customary protected only because the class is sealed.

Verified as far as this machine allows: building the project on Windows
no longer reports CS1729. Two errors remain and neither is this one —
CS5001 (no entry point, which the iOS SDK is expected to generate) and
MA0049 (type name matches its namespace). Both predate this change and
both want a real iOS build, or a decision, rather than a guess.

* fix: make the notification service extension compile

Clears the last two errors, and the project now builds. So do the iOS
and MacCatalyst heads, which had never built here either — the extension
is referenced by the app under ios, so its errors were theirs too.

CS5001, no entry point. An iOS app extension is a separate binary the
system launches in its own process, so the project is OutputType=Exe and
Roslyn wants a Main. The SDK does not supply one: Xamarin.GenerateMainStep
is a linker step that runs during the native build and produces the
native main, while the managed entry point is the projec... (continued)

955 of 993 relevant lines covered (96.17%)

18.49 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33080820098.1 13
96.17
GitHub Action Run
Source Files on build 33080820098