bleedingdeacons / reach / 33085017091
86%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 90
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.56% (+0.02%) from 88.54%
33085017091

push

github

web-flow 
feat: clear an answered message from every other handset

* feat: clear an answered message from every other handset

A broadcast rings the whole rota, and until now every handset it reached
was left holding the alert after somebody had taken the job. The notice
told them who had answered; it did not take the thing off their screen,
so thirty people still dismissed the same message one by one.

Now an answered message is over, for everybody. Any acknowledgement
against any row of a message drops that message from the poll, so a
handset that has removed it locally on the notice does not get it handed
straight back on the next poll. Hand is the fast path here and this is
the durable one, which is the same division as the rest of this feature.

Counted across the message rather than the row, so the admin-message
case works: one message to a responder holding a phone and a tablet is
two device-targeted rows, and answering on the phone should take it off
the tablet rather than leave the same person dismissing the same message
twice.

Two exemptions, both load-bearing. A notice is addressed to everybody
and read by each of them separately, so the fastest handset to press
Close must not decide nobody else gets to read who answered; suppression
is therefore keyed on kind, because that is the real distinction — an
alert is a job one person takes, a notice is news everybody gets. And
every row written before message_uuid existed shares the empty string,
so matching on it would let any one of them silence all the others.

What it costs: Recent alerts can no longer answer "did *this* handset
ring" for both of a responder's handsets, only which one answered. That
is the intended trade.

* docs: reconcile the multi-handset note with the new suppression rule

The 'one send, one message' section still said each handset carries its
own acknowledgement and a silent one cannot hide behind the other
answering. This branch reverses exactly that, so the file argued with
it... (continued)

5721 of 6460 relevant lines covered (88.56%)

13.76 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
96.67
0.05% reach/reach/src/Alerts/WpdbAlertRepository.php
Jobs
ID Job ID Ran Files Coverage
1 33085017091.1 90
88.56
GitHub Action Run
Source Files on build 33085017091