bleedingdeacons / reach / 33070039044
86%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 90
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.54% (+0.3%) from 88.289%
33070039044

push

github

web-flow 
feat: give every message a uuid, and tell the rota when one is answered

* feat: give every message a uuid, and tell the rota when one is answered

Two things a handset could not previously know: which alerts are one
message, and that somebody else has already picked one up.

**A message uuid.** Every alert gets one; every alert raised by the same
send shares it. Usually that is a distinction without a difference — a
broadcast is one row addressed to everybody — but an administrator
messaging a responder who holds a phone and a tablet raises one alert
per handset on purpose, so each carries its own acknowledgement and a
silent handset cannot hide behind the other one answering. Nothing said
those two rows were one thing. Callers may supply their own to join
alerts deliberately; a malformed one is replaced rather than refused,
because a send must not fail over an identifier that exists to group
rows for display.

**An acknowledgement notice.** A broadcast rings every certified handset
at once and the first responder to answer silences only their own.
Everybody else's went on shouting about a job already being done, and
they found out it was done by acknowledging it themselves — woken for
nothing, and then telling Reach they had dealt with something they had
not. The acknowledgement was recorded all along; it simply never went
anywhere a handset could see it.

So an acknowledgement now raises a second message, kind
message_acknowledged, addressed to everybody the first went to except
the handset that answered, naming who picked it up. Recipients are
recovered from every row sharing the uuid, because the answered row
names only its own handset. Three guards: never urgent, whatever it
reports on; never raised for a notice, or one answered call becomes an
unbounded correspondence; and only the first answer is announced —
without that, thirty responders each pressing Close turns one callback
into nine hundred deliveries.

The exclusion is honoured in all th... (continued)

5717 of 6457 relevant lines covered (88.54%)

13.57 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
95.42
-0.38% reach/reach/src/Rest/AlertController.php
5
96.62
0.36% reach/reach/src/Alerts/WpdbAlertRepository.php
3
95.4
1.73% reach/reach/src/Alerts/AlertRequest.php
2
97.47
0.03% reach/reach/src/Admin/SendMessagePage.php
2
88.46
0.0% reach/reach/src/Core/Schema.php
Jobs
ID Job ID Ran Files Coverage
1 33070039044.1 90
88.54
GitHub Action Run
Source Files on build 33070039044