kubeflow / trainer / 33006312598

70%

push

github

fix(framework): keep unnamed container ports when upserting (#3926)

byContainerPortOrName treated two container ports as the same port when
both omitted the optional name field, because ptr.Equal(nil, nil) returns
true. Upserting the trainer port 29500 therefore overwrote the first
unnamed port declared by the runtime template instead of appending it,
silently dropping that port from the generated JobSet. The protocol was
not compared at all, so ports that Kubernetes treats as distinct
collapsed into a single entry.

Compare ports the way Kubernetes keys the list, by containerPort and
protocol, and only match on name when both ports set one.

The "insert new port" test case asserted the previous behaviour despite
its name, so its expectation is corrected here.

Fixes #3925

Signed-off-by: Aarushi Tandon <aarushi.tandon0@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

2673 of 3835 relevant lines covered (69.7%)

0.81 hits per line