kubeflow / trainer / 33005941951

70%

push

github

chore(controller): unit test TrainJob deadline reconciliation with a fake clock (#3915)

reconcileDeadline returns a ctrl.Result whose RequeueAfter drives the next
deadline check, but nothing asserted that value. The integration tests poll
with Eventually/Consistently and only observe the resulting conditions, so
the requeue arithmetic, the one-second floor, the zero start time guard and
the resume-transition start time were all uncovered.

They were also not assertable, because reconcileDeadline read the wall clock
directly. Give TrainJobReconciler a clock.PassiveClock, defaulted to
clock.RealClock in the constructor, so tests can substitute a fake one and
compare the result exactly. This mirrors what TrainJobDefaulter already does
in pkg/webhooks. time.Until is replaced by deadline.Sub(now) so both reads
come from the same source.

Behaviour is unchanged with a real clock.

Fixes #3914


Assisted-by: Claude Opus 5

Signed-off-by: sumedh charjan <sumedhcharjan321@gmail.com>

2 of 3 new or added lines in 1 file covered. (66.67%)

2667 of 3832 relevant lines covered (69.6%)

0.81 hits per line