Tatsh / wiswa / 32929567277

100%

push

github

github/workflows/pyinstaller: attach the archives, not the binaries

Every matrix job builds its binary under the same name: macOS produces
dist/<name> and Windows dist/<name>.exe whatever the architecture. The
release job downloaded all of them with merge-multiple, which flattens
them into one directory, so the second of each pair overwrote the first.
A four-way matrix therefore shipped two assets, and neither said which
architecture it was.

The workflow already built an archive per job carrying both the version
and the architecture, and already attested it, but nothing uploaded it,
so the release job fell back to the colliding binaries. Upload those
archives and have the release job take them instead.

An archive is the better asset besides: a release keeps no executable
bit, and macOS notarisation does not survive a loose binary.

Found on dade v0.0.1, which built four binaries and released two.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

780 of 780 branches covered (100.0%)

Branch coverage included in aggregate %.

2015 of 2015 relevant lines covered (100.0%)

5.0 hits per line