Rotorsoft / act-root / 32896299477

100%

push

github

fix(act): apply the lane guards to dynamic resolutions (#1575)

* fix(act): apply the lane guards to dynamic resolutions

A build-time guard only ever sees a static `.to({lane})` — a `.to(fn)` lane
is a function until an event arrives — so both lane checks exempted dynamic
resolvers. Correlate is where the lane finally exists, so the same rules
apply there.

An undeclared lane is rerouted to "default" and reported: no controller
claims it, so the stream otherwise sat at watermark -1 forever, invisible to
blocked_streams() and every other health surface. A disagreement between two
equal-priority resolutions keeps the first-discovered lane and reports the
conflict; the lane is not corrected mid-run, because a live stream's lane is
the one its in-flight leases were taken under.

Reported, never thrown — a throw inside correlate pins the checkpoint for the
whole app (#1420). Each offending declaration reports once, off a set owned
by the correlator instance so internal/ keeps no module state.

Closes #1564
Closes #1567

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K5eB6CMELZJfayCYpQta8N

* refactor(act): share the report-once helper between drain and correlate

Both pipelines report a misdeclaration a build-time guard could not catch,
and both need the same dedup: a resolver fires for every matching event, so
a naive log turns one bad declaration into a line per event.

The dedup moves to internal/report-once.ts and warn_misrouted keeps only its
message. Not src/utils.ts — that is re-exported from the public barrel, and
this is implementation detail.

Also reattaches run_drain_cycle's doc block, which warn_misrouted was
inserted in front of.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K5eB6CMELZJfayCYpQta8N

---------

Co-authored-by: rotorsoft <rotorsoft@outlook.com>
Co-authored-by: Claude Opus 5 (1M context) <no... (continued)

4302 of 4302 branches covered (100.0%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 4 files covered. (100.0%)

9274 of 9274 relevant lines covered (100.0%)

1169.98 hits per line