grobidOrg / grobid / 32835362816

43%

master: 43%

Pull #1375

github

typedAreas: an unreadable payload means no masking, not a failed request

Splits the two failures apart, which a354506ac had lumped together.

A payload that cannot be read as a list of areas at all -- not JSON, or JSON
that is not an array -- now behaves exactly as if the parameter had been
omitted: the request proceeds unmasked and returns 200, with the reason logged
at ERROR. The caller plainly did not supply a mask list, and failing the whole
request buys nothing.

A payload that *is* a list but carries an unusable entry still aborts with
HTTP 400. That is the case worth failing on: the caller did supply masks, and
applying a subset of them is never what they wanted -- it used to return an
ordinary 200 having quietly dropped boxes, which is invisible and contaminates
a batch run.

Verified against a running service, same PDF throughout:

  not JSON                  -> 200, 14 figures  (= no-parameter case)
  JSON object, not an array -> 200, 14 figures  (= no-parameter case)
  empty / omitted           -> 200, 14 figures
  array, unknown type       -> 400 rejected 1 of 1 entries: [0] Unknown area type: banana
  array, missing 'type'     -> 400 rejected 1 of 1 entries: [0] missing required 'type' field
  valid single area         -> 200, 15 figures

10180 of 26253 branches covered (38.78%)

Branch coverage included in aggregate %.

21339 of 47152 relevant lines covered (45.26%)

1.84 hits per line