supabase / supabase-flutter / 32824434652

89%

push

github

fix(storage): normalize object paths consistently across all file operations (#1761)

## Problem

Path normalization (`_removeEmptyFolders`, which strips leading and
trailing `/` and collapses `//`) was applied only to `upload`,
`uploadBinary`, `uploadToSignedUrl`, `uploadBinaryToSignedUrl`,
`update`, and `updateBinary`.

It was not applied to `createSignedUrl`, `createSignedUploadUrl`,
`download`, `downloadStream`, `getMetadata`, `exists`, `getPublicUrl`,
or `purgeCache`; those only went through `_getFinalPath`, which
percent-encodes segments but did not strip slashes. The payload-based
operations `move`, `copy`, `remove`, `list`, and `createSignedUrls` sent
raw paths in their JSON bodies as well.

Result: `upload('/folder/a.png')` stores the object under
`folder/a.png`, but a subsequent `createSignedUrl('/folder/a.png')`,
`download('/folder/a.png')`, or `remove(['/folder/a.png'])` targeted a
different key and failed.

This mirrors the fixes in supabase-swift
([supabase/supabase-swift#1111](https://github.com/supabase/supabase-swift/pull/1111),
[supabase/supabase-swift#1108](https://github.com/supabase/supabase-swift/pull/1108))
and extends them to the payload-based operations.

## Fix

- `_getFinalPath` now runs `_removeEmptyFolders` before
percent-encoding, so every operation that builds an object URL through
it normalizes the path the same way as the upload methods.
- `_removeEmptyFolders` now collapses duplicate slashes before stripping
leading and trailing ones, so inputs like `//folder//file.txt//` fully
normalize to `folder/file.txt` (the previous order left a leading slash
behind for doubled leading slashes).
- `createSignedUploadUrl` cleans the path before building the request
URL and returns the cleaned path in `SignedUploadURLResponse.path`, so
the returned path matches the stored object key, mirroring the Swift
fix.
- `move`, `copy`, `remove`, `list`, and `createSignedUrls` normalize the
paths in their JSON bodies, so payload-based operat... (continued)

15 of 15 new or added lines in 1 file covered. (100.0%)

6029 of 6801 relevant lines covered (88.65%)

4.57 hits per line