supabase / supabase-flutter / 32823468489

89%

push

github

fix(realtime): surface access-token provider errors on connect instead of logging and continuing (#1759)

## What kind of change does this PR introduce?

Bug fix.

## What is the current behavior?

When a custom `accessToken` provider throws while the realtime socket
connects, `_resolveAccessTokenAndFlush` logs `Error resolving access
token on connect` and flushes the send buffer anyway. The buffered
channel joins are then sent with whatever identity the socket already
has (typically the anon/publishable key), so a transient third-party
auth failure silently downgrades the connection instead of failing it.
The HTTP path already propagates these errors, and supabase-swift
adopted the same behavior citing supabase-flutter as the reference
implementation, so realtime was the odd one out.

## What is the new behavior?

A throwing access-token provider now fails the connect and surfaces the
error on both levels:

- Pending subscriptions receive a `channelError` status carrying the
provider's actual error through `RealtimeChannel.onStatusChange`.
- `RealtimeClient.onStatusChange` receives the error as a stream error,
consistent with other connection errors.
- The send buffer is kept unsent, so buffered joins are never flushed
with the wrong identity, and the connection is closed so the existing
reconnect backoff retries the provider on each attempt. Transient
provider failures self-heal, and a provider that returns `null` (no
signed-in user) still proceeds unauthenticated.

The errored-channel rejoin loop also moved from `_onConnectionOpen` to
after the token resolution, so rejoins always carry the resolved
identity. Previously an errored channel rejoined immediately on
reconnect with the stale payload, which both reintroduced the
wrong-identity join after a provider failure and, on the success path,
sent a stale join that was corrected by a second one.

A guard bails out of the error handling when a disconnect or reconnect
replaced the connection while the... (continued)

31 of 32 new or added lines in 1 file covered. (96.88%)

6024 of 6796 relevant lines covered (88.64%)

4.5 hits per line