coreui / coreui-pro / 32769242399

93%

main: 94%

push

github

feat(links)!: colour a link with the theme, not a class per colour (#876)

`.link-{color}` predates the theme slots. It painted a link with the raw brand
colour and computed its `:hover` shade in Sass — so the hover was frozen at build
time, and overriding `--cui-primary` at runtime never reached it. Sixteen such
frozen colours leave the stylesheet with these classes.

Reboot already resolves a link's colour from `--cui-theme-fg`, and every
`.theme-*` class sets that token, so the replacement was in place and undocumented:
`<a class="theme-primary">` is what `<a class="link-primary">` was for.

The theme slot is a tone picked for text rather than the brand colour itself —
`light-dark(600, 400)`, so it darkens on a light background and lightens on a
dark one. The old class gave the same colour in both, which is why it read poorly
in dark mode. Measured across all eight colours and both modes, the slot is the
higher-contrast choice in 16 of 16 pairings and halves the WCAG AA failures, from
10 to 5. The five that remain are a property of the palette's lightness spread,
not of this change — measured and recorded under the palette rework rather than
patched over here.

`.link-underline` now defaults to `currentColor` instead of the global link
colour, so it follows the theme rather than staying blue under themed text. Name
a colour with `.link-underline-{color}` to break that pairing on purpose.

`.link-body-emphasis` goes too; `.text-body-emphasis` is the same thing. The
`helpers/colored-links` page was already a lesser copy of the link utilities
section and is gone, redirecting there.

4532 of 5097 branches covered (88.92%)

Branch coverage included in aggregate %.

8653 of 9054 relevant lines covered (95.57%)

400.06 hits per line