PHPOffice / PHPPresentation / 32722828734

93%

push

github

A six-digit colour is no longer given an alpha it never asked for (#910)

`Color::getAlpha()` read the first two characters of the value as the alpha whenever the string was
six characters or more. So the plain RGB form the class documents -- and the one its own
documentation uses, `new Color('C00000')` -- came back 75% opaque, `D0D0D0` 82% and `71C569` 44%.
`writeColor()` writes that number into `<a:alpha>` for every font, bullet, border and fill, so it
reached the file: a colour nobody asked to be translucent was written translucent.

Six characters are an RGB, and an RGB is opaque. Only the eight-character form carries an alpha, in
the two characters in front of the colour, and `getRGB()` already tells the two apart.

`setAlpha()` had the same blind spot from the other side: it wrote the alpha over the first two
characters of the value, so `D0D0D0` given an alpha became the colour `80D0D0`. It now keeps the
colour whole.

2 of 2 new or added lines in 1 file covered. (100.0%)

10339 of 11185 relevant lines covered (92.44%)

51.85 hits per line