PHPOffice / PHPPresentation / 32711082632

93%

push

github

PowerPoint2007 Reader : Read a text run that was written without properties (#914)

* Added support for loading text run without properties

* Guard the text of a run that has no properties, and pin both with tests

The run is now made before `a:rPr` is looked at, which also moved `setText()`
out from under that guard -- so a run without `a:t`, which the schema forbids
but files carry anyway, reached `$oSubSubElement->nodeValue` on null. Look for
the text rather than assume it.

The tests write a deck, take `a:rPr` (or `a:t`) back out of the archive and read
it again, so neither needs a binary fixture. Keynote is the export that hits
this: one of its slides carries runs with text and no `a:rPr` at all, and every
one of them was read as nothing.

The seven `is_object()` checks in the rewritten block are now
`instanceof DOMElement` -- what the other ninety-four checks in this file use,
and what `getElement()` promises.

---------

Co-authored-by: Phil Wilkinson <phil.wilkinson@gomolearning.com>

10 of 10 new or added lines in 1 file covered. (100.0%)

10339 of 11185 relevant lines covered (92.44%)

51.71 hits per line