ruby-grape / grape / 32704482288

97%

master: 97%

Pull #2859

github

Answer Route#success and #failure whichever way desc spelled them

`success` and `failure` are grape's documented names for `entity` and
`http_codes` (README, and `alias success entity` in ApiDescription), but
a route could only answer one spelling: the one the description happened
to use.

A `desc` block records `success Entity` under `:entity`, so `route.success`
found no `:success` key; a keyword `desc 'x', success: Entity` keeps the
key it was written with, so `route.entity` found no `:entity` key. Both
calls still returned nil rather than raising, because BaseRoute delegates
missing methods to its options bag and ActiveSupport::OrderedOptions
answers an unknown reader with nil.

Define the two readers on BaseRoute so each resolves the description's
value from either key. grape-swagger already compensates for this with
`route.entity || route.success`, but its `file_response?(route.success)`
check saw nothing for a description written as a block.

`entity` and `http_codes` still read only their own key, so the error
formatter's presenter lookup keeps missing a `failure:` keyword option;
that one is left for a follow-up.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1239 of 1330 branches covered (93.16%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

3881 of 3949 relevant lines covered (98.28%)

27088.17 hits per line