roundup-tracker / roundup / 32683767230

75%

push

github

feat: issue2551332: roundup-admin updateconfig preserves DEFAULT and interpolation tokens.

The main config.ini has supported interpolation with %(name)s tokens
in values. However roundup-admin's upgradeconfig would wipe any names
that weren't defined in the config schema. Also it would write out the
values of the interpolation tokens and not preserve the tokens.

This checkin defines a DEFAULT section and preserves the names/values
defined in the DEFAULT section of the file. Names/tokens not in the
config schema are not preserved in any other section of the file. It
also preserves the interpolation tokens.

reference.txt:

  swapped paragraph on schema.py in Tracker Configuration section
  before the paragraph on config.ini so all config.ini stuff is
  together.

  added docs on DEFAULT section

admin.py:

  added better exception handling to prevent full tracebacks on errors
  generated by interpolation support and DEFAULT section support.

  put python3 UserDict import in try section not except section.
  Need to do more investigation before I remove pure UserDict import.

  in do_genconfig() do early return if we are not updating config.

configuration.py:

  add attribute to store raw version of value for each Option also add
  method for setting.

  make format() output in raw mode as well, add rformat() as wrapper.

  make save() (of config) optionally output in raw mode, write DEFAULT
  section and default values.

  use textwrap dedent/wrap for cleaning/reformatting text.

  remove python 2 support for importing configparser

  cleanup import order a little.

  OptionValueError reports file (for detectors/extensions config.ini)

  _adjust_options: remove unneeded list() around
  config.defaults().keys()

test_admin.py:

  use pathlib.Path for path munging in new code.

  fix replace_in_file() to not add an extra newline for every line.

  add subtests fixture

  add three tests:

     config.ini file w/ DEFAULT section with boolean definition... (continued)

46 of 52 new or added lines in 2 files covered. (88.46%)

18941 of 25428 relevant lines covered (74.49%)

5.18 hits per line