microlinkhq / browserless / 32660964695

80%

push

github

fix(screenshot): bound the capture navigation retry (#898)

* ci: use the same npmrc auth as metascraper

lerna reads the committed ${NPM_TOKEN} line. lockfile=false
keeps the tree clean so publish does not hit EUNCOMMIT.

Co-authored-by: Cursor <cursoragent@cursor.com>

* ci: set lockfile false where pnpm 11 reads it

pnpm 11 ignores non-auth .npmrc keys. Keep ${NPM_TOKEN}
there for lerna; put lockfile: false in the workspace
manifest and ignore the generated lockfile.

Co-authored-by: Cursor <cursoragent@cursor.com>

* revert: drop lockfile false from the workspace manifest

pnpm 11 then resolved workspace packages from npm
and install failed looking for unpublished 13.9.0.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(screenshot): bound the capture navigation retry

A closed page or session is terminal, not transient: `waitUntilAuto`
resolves at once against it, so the retry loop spun with no delay for the
whole capture budget (~409k iterations in 750ms in test, pegging a thread
and flooding logs until the timeout expired).

Bail out when the page is closed and pace each retry, so a destroyed
context on a live page still retries as before.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FQGzhKLzWo14WbZ62LRdu9

* fix(screenshot): stop retrying once the capture budget is spent

A wait that consumed the remaining budget still let one more capture
through, so a slow success could return past the timeout. Recheck the
deadline after the wait and rethrow instead.

Teach the pdf page doubles to answer `isClosed`, as a real page does.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FQGzhKLzWo14WbZ62LRdu9

* refactor(screenshot): pace the capture retry at the readiness poll cadence

The retry floor was an invented constant. Reuse `DEFAULT_POLL_MS`, the
cadence this package already re-checks a page it is waiting o... (continued)

936 of 1137 branches covered (82.32%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 3 files covered. (100.0%)

4538 of 5743 relevant lines covered (79.02%)

87250.55 hits per line