coreui / coreui-pro / 32653730929

94%

main: 94%

push

github

feat(Popover, Tooltip): move the fade to CSS, fill the bottom arrow like its header (#855)

* fix(Popover): fill the bottom arrow like the header it points into

A bottom-placed popover puts its arrow above the header, and the arrow was
drawn in the body background — so it read as a notch cut out of the header
strip. It takes `--cui-popover-header-bg` when a header follows it, and stays
on `--cui-popover-bg` when there is none.

Removes `$popover-arrow-color` and `$popover-arrow-outer-color`, deprecated in
4.2.0 and wrapped in `fusv-disable` because nothing reads them.

Removes the eight `rtl:ignore` directives from the popover and tooltip arrows.
They address rtlcss, which this repo does not run — no script, no build step,
no workflow invokes it — so they were shipping to `dist` as inert comments.
The arrow geometry stays on physical properties on purpose: `AttachmentMap`
already resolves `right`/`left` through `isRTL()`, so `data-coreui-placement`
and the `.bs-popover-*` classes are physical, and a logical border colour would
paint the wrong edge of the triangle under `dir="rtl"`.

`--cui-popover-font-size` and `--cui-popover-header-font-size` gain the
interpolation every other entry in the map had, and move to the groups they
belong to instead of trailing the map.

* feat(Popover, Tooltip): move the fade to CSS

Both tips faded through a `fade` helper class the JS added and removed. The
transition lives in the stylesheet now, driven by `.show` with `@starting-style`
supplying the state to animate from, and exposed as
`--cui-{popover,tooltip}-transition-property/-duration/-timing`. `animation:
false` renders `.popover-instant` / `.tooltip-instant` instead of omitting
`fade`, so a custom `template` opts out through the same class — the same shape
the toast already uses.

`--cui-popover-header-color` reads `--cui-heading-color` rather than resolving
`$headings-color` at build time, so a runtime override of the heading colour
reaches the popover header... (continued)

4530 of 5095 branches covered (88.91%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

8652 of 9053 relevant lines covered (95.57%)

400.16 hits per line