Rotorsoft / act-root / 32645275341

100%

push

github

fix(act): keep the claim lane filter when onlyLanes narrows to default (#1548)

The single-lane collapse, which builds a controller with no lane so the
adapter's claim keeps its pre-lanes query shape, keyed on the ACTIVE lane
set. A worker booted with `onlyLanes: ["default"]` against an app that
declares lanes produced an active set of exactly ["default"], which is
indistinguishable from an app that never called withLane, so the
controller was built with `lane: undefined`. The lane argument on claim
is an optional filter and omitting it selects every lane, so the worker
narrowed to one lane claimed all of them: it ran the other lanes'
handlers itself, on the fallback lease instead of their declared budget,
while the workers that own those lanes found nothing to do. The startup
advisory reported those lanes as orphaned on the very instance that was
about to drain them.

The collapse now keys on the DECLARED universe. It applies only when no
lane was ever declared, which is the case it exists for; once any lane
is declared the implicit default is an ordinary filtered lane.

Closes #1545

Co-authored-by: rotorsoft <rotorsoft@outlook.com>

4235 of 4235 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

9191 of 9191 relevant lines covered (100.0%)

1328.7 hits per line