coreui / coreui-pro / 32644124500

93%

main: 94%

push

github

fix(Check, Radio, Switch): keep the themed border on focus, and document the slot rule (#850)

* fix(Check, Radio, Switch): keep the themed border on focus

:focus-visible overwrote border-color with --cui-*-focus-border, which
resolves to the primary focus border and carries no theme slot. A themed
control therefore dropped its color the moment it took keyboard focus: a
.theme-success checkbox went from a green border to a lavender one while
its focus ring stayed green.

The ring already marks focus on its own, so the override goes and the
border keeps whatever the state set. The three tokens existed only to feed
it and are removed with it. Unthemed controls no longer get a primary
border on focus; the ring is the focus affordance.

* docs(Customize): state the rule for building a themeable component

The theme-variants page showed how badge consumes theme tokens but never
said that the slot's position is load-bearing. Reading a slot around a
component token instead of inside its default inverts precedence: the theme
starts beating the token, which kills every structural variant, since a
variant is a rule that redeclares that token.

Documents both forms side by side, what each does when the token is
overridden, how the rule applies to a state that remaps a token, and the
consequence that a token declared on the component root cannot see a theme
class placed on one of its parts.

4533 of 5098 branches covered (88.92%)

Branch coverage included in aggregate %.

8652 of 9053 relevant lines covered (95.57%)

400.23 hits per line