dennisdoomen / packageguard / 32631513776

81%

Build Type

push

github

Committed by web-flow

Commit Message

Share one resilient GitHub client across the whole run (#239)

* Share one resilient GitHub client across the whole run

PackageGuard talked to api.github.com from two places, each with its own
HttpClient and neither aware of the rate limit. Risk enrichment ran six
packages at a time, and every package fanned out into per-issue and
per-pull-request calls behind their own semaphores, so well over a hundred
requests could be in flight at once. GitHub answers that with 403 under its
secondary rate limit, which the code then reported as a failure to fetch
metadata.

Route every GitHub request through one GitHubApiClient that:

- caps concurrency at 8 requests, far below the 100 GitHub allows;
- honours retry-after and x-ratelimit-reset, retrying short throttles;
- stops making requests once the budget is spent, and says so once, rather
  than spending the rest of the run collecting rejections;
- skips requests marked optional when the budget drops into a reserve, so
  the packages still to be scanned keep getting their essential signals;
- revalidates responses with If-None-Match against a cache stored next to
  cache.bin, and remembers which resources do not exist.

A repository whose metadata could not be read is now cached as such. It used
to be left out of the cache, so all forty packages sharing a repository each
retried the same failing fan-out.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Address the InspectCode findings on the review

Tighten the visibility of members that only the declaring type uses: the rate
limit budget becomes a private field on the client, GetStringAsync becomes
private, and ResetsAt and Reserve become private on GitHubRateLimit.

Drop two members nothing calls: GitHubApi.Reset, which was written for tests
that construct their clients directly, and the ResponseCache property.

Rename the attempt result's IsThrottled to WasThrottled, so it no longer hides
the outer IsThrottled that inspects a response, and drop t... (continued)

Coverage Stats

1801 of 2580 branches covered (69.81%)

Branch coverage included in aggregate %.

409 of 469 new or added lines in 8 files covered. (87.21%)

3 existing lines in 1 file now uncovered.

5624 of 6871 relevant lines covered (81.85%)

1804.11 hits per line