MewX / light-novel-library_Wenku8_Android / 32631254437

36%

master: 36%

Build Type

push

github

Committed by MewX

Commit Message

Covering the migration flag and the per-file copy, and correcting two comments

The flow that touches all of a user's data on upgrade had two tests, both about
the shape of a path string. SaveFileMigrationFlowTest adds eleven over the parts
that decide whether it works: the completion flag lifecycle -- mark, revert, mark
twice, revert when unset, and that it is a real file on disk -- and the per-file
copy, covering content fidelity, relative path preservation under the root,
folder creation, an empty file surviving as empty, and a missing source not
leaving something that reads as migrated, which is how MainActivity counts a
failure.

The flag is the dangerous thing to test and every case restores it.
.migration_completed feeds StorageRoots.setInternalOnly through loadAllSetting,
so a test that left it flipped would change which directory the whole app reads
and writes, for the rest of the process and the next launch too, since it is on
disk. Verified by checking the flag is present before and after a full run.

generateMigrationPlan's override branch is left uncovered on purpose: it resolves
through DocumentFile.fromTreeUri, which needs a real Storage Access Framework
tree Uri granted by the user, and a file Uri would exercise something else. The
gap is named in the class and in the plan rather than papered over.

Also corrects a comment that was simply wrong. ReadSaves and ReadSavesV1 both
carried // deprecated. Neither is: they are the two readers' position formats,
one a pixel scroll offset keyed by cid for the vertical reader, the other a line
and word index keyed by aid for the paged reader, and neither converts into the
other. Anyone reading the class would have concluded one replaced the other.

Step 3 marked deferred by decision until the backend migration is scheduled,
since it is that work's prerequisite and buys nothing before it.

Full suite of 195 passes, with the save folder byte-identical before and after.

Co-Authored-By: Claude <nore... (continued)

Coverage Stats

926 of 3240 branches covered (28.58%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

10 existing lines in 2 files now uncovered.

2779 of 7058 relevant lines covered (39.37%)

1.88 hits per line