Rotorsoft / act-root / 32607202617

100%

push

github

ACT-1541 fix(act): make reactingTo injection ambient across reaction dispatches (#1542)

* fix(act): make reactingTo injection ambient across reaction dispatches

The scoped IAct proxy auto-injected the triggering event only for handlers
that dispatched through the injected third argument. A handler closing over
a module-level `app` — the ordinary shape when the app is a module export —
bypassed the proxy, so the commit minted a fresh correlation id and left
causation.event undefined. The reaction still ran and still committed; only
the causal record was lost, silently.

Install the triggering event in an AsyncLocalStorage around the handler and
fall back to it in action(), so every dispatch reached from inside a reaction
threads the chain regardless of which IAct reference made the call. Explicit
reactingTo still wins. Batch projection handlers are out of scope: no IAct,
many events, no single triggering event to inherit.

This makes the code match what state-management.md already documented.

Closes #1541

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K5eB6CMELZJfayCYpQta8N

* test(act): cover ambient reactingTo on the singleton-port path

The sandbox cases build with ActOptions.scoped, which installs the ports
ALS. The reporting app runs the other configuration: reactions declared
straight on act() with no slice, ports injected via the singleton
store(adapter), so _scoped is the identity wrapper. Pin that shape too.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K5eB6CMELZJfayCYpQta8N

* refactor(act): drop the per-payload do rebinding made redundant by ambient context

With action() resolving reactingTo from the ambient reaction context, the
scoped proxy's per-payload `do` override computed exactly the same value
the orchestrator now derives on its own. Two mechanisms, one result.

Delete the rebinding: `scope... (continued)

4237 of 4237 branches covered (100.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 3 files covered. (100.0%)

9191 of 9191 relevant lines covered (100.0%)

1331.96 hits per line