archetech / archon / 32587571746

87%

push

github

fix(ci): Seed native prebuilds in the three jobs that were missed (#926)

* fix(ci): Seed native prebuilds in the three jobs that were missed

Closes #913.

Not a new problem: #879 already removed the network from this path by
seeding ./prebuilds before the image build, since sqlite3's install script
is `prebuild-install -r napi || node-gyp rebuild` and the slim base images
have no toolchain for the fallback to use. Its own commit message says it
covered "the three workflows that now run the prefetch" -- but six jobs
build images, and three were left out:

- python-sdk-tests.yml, which is where #913's failure was observed
- docker-build-test.yml :: build_test_images, which builds through
  start-node-ci, so the build is invisible to a grep of the workflow
- docker-build-test.yml :: gatekeeper_parity, `up -d --build`

All three are PR-triggered, which is why the symptom was a spurious red
check on any PR.

The issue asked to check option 3 first -- drop sqlite3 if the images do
not use it. They do: services/keymaster/server/src/keymaster-api.ts:12
imports WalletSQLite statically and instantiates it at :256, and the
gatekeeper imports it dynamically. It is a supported backend, so removing
it was never available.

The guard checks per JOB, not per file: docker-build-test.yml has two
image-building jobs and covering one would look right from outside, which
is close to how the original miss happened. It also checks that a
Dockerfile copying prebuilds/ points prebuild-install at it, since one
without the other silently falls back to the network.

Mutation-tested three ways -- reverting python-sdk-tests, dropping the
prefetch from only the second job, and removing a Dockerfile's env var --
each turns it red. The prefetch script was run rather than assumed to
work: all four tarballs fetched.

tests/ci uses `yaml` rather than js-yaml because it ships its own types,
so this declares one dependency instead of two. Both were undeclared
transitives; #924's review ... (continued)

3806 of 4293 branches covered (88.66%)

Branch coverage included in aggregate %.

8465 of 8776 relevant lines covered (96.46%)

689.48 hits per line