archetech / archon / 32585001255

87%

push

github

fix(test): Typecheck tests in CI, and clear the 416 errors hiding there (#924)

* fix(test): Typecheck tests in CI, and clear the 416 errors hiding there

Closes #923.

tsconfig.json covers tests/, but nothing ever ran tsc over it: the build
script compiles the workspace packages only, and isolatedModules means
ts-jest transpiles per file without cross-file checking. So type errors in
tests were invisible, and 416 had accumulated.

That is not cosmetic. A fixture typed against a production interface --
the fix for #922's review -- was a guard nothing enforced. Reverting one
to the wrong shape now fails `npm run typecheck` where before it passed
the whole suite green.

Mechanical sweeps, ~300 of the 416:
- 77 relative imports given explicit extensions (targets verified on disk,
  never guessed; .js where the target really is JavaScript)
- 221 bare jest.fn() typed as jest.fn<any>(), matching the 261 already
  written that way, plus the jest.Mock aliases behind them

Two config changes let the program see what the services already answer:
- services' declarations.d.ts and express.d.ts added to include, so
  ambient module shims are in scope
- express types pinned to one copy. Each service carries its own, so an
  app from the root copy and a Router from a service copy were different
  nominal types and app.use(path, router) had no matching overload.

Real problems the typechecker found once it could run:

- client.test.ts passed { name } to createFileStream, which takes
  `filename`. Four call sites asserting an option the API ignores.
- Its mockPoll was still a v1 poll -- `type`, `version: 1`, `roster` --
  where PollConfig has been v2 with `name` since. nock answers whatever is
  sent, so nothing noticed.
- response.test.ts, named "should verify a response if credential is
  updated", assigned `credential2.credential`. The claims live in
  credentialSubject, so it was not updating a credential.
- l402-auth.test.ts's store fake omitted checkAndRecordCos... (continued)

3806 of 4293 branches covered (88.66%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 4 files covered. (100.0%)

8465 of 8776 relevant lines covered (96.46%)

689.48 hits per line